Differences

This shows you the differences between two versions of the page.

--- contributing [2023/06/01 12:02] – update branch name from master to main gmcharlton
+++ contributing [2025/03/20 12:18] (current) – jdavis
@@ Line 161: / Line 161: @@
     * Any time a patch adds or alters a stored procedure, pgTAP tests that exercise its intended functionality should be included.
     * A change to database or Perl code that fixes a bug should be accompanied by a Perl (t or live_t) or pgTAP regression test – or by a statement from the patch author explaining why a test is infeasible without significant refactoring. In the latter case, it is expected that an extra signoff be obtained before the patch is merged.
+    * Changes to the Angular staff client should be run through a linter to catch inconsistencies and common errors (cd Open-ILS/src/eg2 && npx ng lint).
   * New features should be accompanied by a file in the repository under the docs/RELEASE_NOTES_NEXT/ directory.  The file should be in asciidoc format and contain enough description to enable the documentation team to write something coherent about the new functionality.  The name of the file should match the feature.  No numbering, etc. is required.  With each release, the contents of this directory will be appended to the release notes. [[contributing:release_notes|See Tips for Writing Release Notes]]
   * Bug fix patches should explain how to test the bug fix in the commit message.