Differences

This shows you the differences between two versions of the page.

--- dev:code_review [2025/08/11 15:24] – created sleary
+++ dev:code_review [2025/09/04 12:31] (current) – limit critical & high priority lists to those with PR tags sleary
@@ Line 1: / Line 1: @@
-[[https://bugs.launchpad.net/evergreen/+bugs?orderby=-importance&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=DEFERRED&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&assignee_option=any&field.milestone%3Alist=103023&field.milestone%3Alist=103024&field.milestone%3Alist=98657&field.milestone%3Alist=64682&field.tags_combinator=ALL&field.omit_dupes=on|Open pull requests without needs-* tags]]:
+====== Code Review ======
-  * [[https://bugs.launchpad.net/evergreen/+bugs?orderby=-importance&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=DEFERRED&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&assignee_option=any&field.milestone%3Alist=103023&field.milestone%3Alist=103024&field.milestone%3Alist=98657&field.milestone%3Alist=64682&field.tag=pullrequest+i18n+-needsrebase+-needswork&field.tags_combinator=ALL&field.omit_dupes=on|Translations]]
+**[[dev:code_review:meetings|Meetings]]**
-  * [[https://bugs.launchpad.net/evergreen/+bugs?orderby=-importance&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=DEFERRED&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&assignee_option=any&field.milestone%3Alist=103023&field.milestone%3Alist=103024&field.milestone%3Alist=98657&field.milestone%3Alist=64682&field.tag=pullrequest+performance+-needsrebase+-needswork&field.tags_combinator=ALL&field.omit_dupes=on|Efficiency / performance]]
-  * [[https://bugs.launchpad.net/evergreen/+bugs?orderby=-importance&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=DEFERRED&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&assignee_option=any&field.milestone%3Alist=103023&field.milestone%3Alist=103024&field.milestone%3Alist=98657&field.milestone%3Alist=64682&field.tag=pullrequest+eg-grid+-needsrebase+-needswork&field.tags_combinator=ALL&field.omit_dupes=on|Grid]]
+[[https://bugs.launchpad.net/evergreen/+bugs?orderby=-importance&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=DEFERRED&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&field.tag=pullrequest+-needsrebase+-needswork&field.tags_combinator=ALL&field.omit_dupes=on|Open pull requests without needs-* tags]]:
-  * [[https://bugs.launchpad.net/evergreen/+bugs?orderby=-importance&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=DEFERRED&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&assignee_option=any&field.milestone%3Alist=103023&field.milestone%3Alist=103024&field.milestone%3Alist=98657&field.milestone%3Alist=64682&field.tag=pullrequest+reports+-needsrebase+-needswork&field.tags_combinator=ALL&field.omit_dupes=on|Reports]]
-  * [[https://bugs.launchpad.net/evergreen/+bugs?orderby=-importance&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=DEFERRED&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&assignee_option=any&field.milestone%3Alist=103023&field.milestone%3Alist=103024&field.milestone%3Alist=98657&field.milestone%3Alist=64682&field.tag=pullrequest+acq+-needsrebase+-needswork&field.tags_combinator=ALL&field.omit_dupes=on|Acquisitions]]
+**[[https://bugs.launchpad.net/evergreen/+bugs?orderby=-importance&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=DEFERRED&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&assignee_option=any&field.tags_combinator=ALL&field.omit_dupes=on&field.importance%3Alist=CRITICAL&field.tag=pullrequest+-needsrebase+-needswork|Critical PRs]] | [[https://bugs.launchpad.net/evergreen/+bugs?orderby=-importance&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=DEFERRED&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&assignee_option=any&field.tags_combinator=ALL&field.omit_dupes=on&field.importance%3Alist=HIGH&field.tag=pullrequest+-needsrebase+-needswork|High priority PRs]]**
-  * [[https://bugs.launchpad.net/evergreen/+bugs?orderby=-importance&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=DEFERRED&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&assignee_option=any&field.milestone%3Alist=103023&field.milestone%3Alist=103024&field.milestone%3Alist=98657&field.milestone%3Alist=64682&field.tag=cataloging+pullrequest+-needsrebase+-needswork&field.tags_combinator=ALL&field.omit_dupes=on|Cataloging]]
-  * [[https://bugs.launchpad.net/evergreen/+bugs?orderby=-importance&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=DEFERRED&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&assignee_option=any&field.milestone%3Alist=103023&field.milestone%3Alist=103024&field.milestone%3Alist=98657&field.milestone%3Alist=64682&field.tag=circulation+pullrequest+-needsrebase+-needswork&field.tags_combinator=ALL&field.omit_dupes=on|Circulation]]
+===== Modules =====
-  * [[https://bugs.launchpad.net/evergreen/+bugs?orderby=-importance&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=DEFERRED&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&assignee_option=any&field.milestone%3Alist=103023&field.milestone%3Alist=103024&field.milestone%3Alist=98657&field.milestone%3Alist=64682&field.tag=pullrequest+accessibility+-needsrebase+-needswork&field.tags_combinator=ALL&field.omit_dupes=on|Accessibility]]
-    * [[https://bugs.launchpad.net/evergreen/+bugs?orderby=-importance&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=DEFERRED&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&assignee_option=any&field.milestone%3Alist=103023&field.milestone%3Alist=103024&field.milestone%3Alist=98657&field.milestone%3Alist=64682&field.tag=pullrequest+accessibility+dark-mode+-opac+-needsrebase+-needswork&field.tags_combinator=ALL&field.omit_dupes=on|Staff + dark mode]]
+  * [[https://bugs.launchpad.net/evergreen/+bugs?orderby=-importance&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=DEFERRED&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&assignee_option=any&field.tag=pullrequest+admin+-needsrebase+-needswork&field.tags_combinator=ALL&field.omit_dupes=on|Administration]]
-    * [[https://bugs.launchpad.net/evergreen/+bugs?orderby=-importance&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=DEFERRED&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&field.milestone%3Alist=103023&field.milestone%3Alist=103024&field.milestone%3Alist=98657&field.milestone%3Alist=64682&field.tag=pullrequest+accessibility+-dark-mode+-ux-colors+-opac+-needsrebase+-needswork&field.tags_combinator=ALL&field.omit_dupes=on|Staff + everything else]]
+  * [[https://bugs.launchpad.net/evergreen/+bugs?orderby=-importance&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=DEFERRED&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&assignee_option=any&&field.tag=pullrequest+acq+-needsrebase+-needswork&field.tags_combinator=ALL&field.omit_dupes=on|Acquisitions]]
-    * [[https://bugs.launchpad.net/evergreen/+bugs?orderby=-importance&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=DEFERRED&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&assignee_option=any&field.milestone%3Alist=103023&field.milestone%3Alist=103024&field.milestone%3Alist=98657&field.milestone%3Alist=64682&field.tag=pullrequest+opac+accessibility+-needsrebase+-needswork&field.tags_combinator=ALL&field.omit_dupes=on|OPAC]]
+  * [[https://bugs.launchpad.net/evergreen/+bugs?orderby=-importance&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=DEFERRED&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&assignee_option=any&&field.tag=pullrequest+booking+-needsrebase+-needswork&field.tags_combinator=ALL&field.omit_dupes=on|Booking]]
+  * [[https://bugs.launchpad.net/evergreen/+bugs?orderby=-importance&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=DEFERRED&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&assignee_option=any&&field.tag=cataloging+pullrequest+-needsrebase+-needswork&field.tags_combinator=ALL&field.omit_dupes=on|Cataloging]]
+  * [[https://bugs.launchpad.net/evergreen/+bugs?orderby=-importance&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=DEFERRED&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&assignee_option=any&&field.tag=circulation+pullrequest+-needsrebase+-needswork&field.tags_combinator=ALL&field.omit_dupes=on|Circulation]]
+  * [[https://bugs.launchpad.net/evergreen/+bugs?orderby=-importance&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=DEFERRED&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&assignee_option=any&&field.tag=pullrequest+course-materials+-needsrebase+-needswork&field.tags_combinator=ALL&field.omit_dupes=on|Courses]]
+  * [[https://bugs.launchpad.net/evergreen/+bugs?orderby=-importance&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=DEFERRED&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&assignee_option=any&&field.tag=pullrequest+reports+-needsrebase+-needswork&field.tags_combinator=ALL&field.omit_dupes=on|Reports]]
+  * [[https://bugs.launchpad.net/evergreen/+bugs?orderby=-importance&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=DEFERRED&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&assignee_option=any&&field.tag=pullrequest+opac+-needsrebase+-needswork&field.tags_combinator=ALL&field.omit_dupes=on|OPAC]]
+===== Infrastructure =====
+  * [[https://bugs.launchpad.net/evergreen/+bugs?orderby=-importance&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=DEFERRED&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&assignee_option=any&&field.tag=pullrequest+i18n+-needsrebase+-needswork&field.tags_combinator=ALL&field.omit_dupes=on|Translations]]
+  * [[https://bugs.launchpad.net/evergreen/+bugs?orderby=-importance&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=DEFERRED&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&assignee_option=any&&field.tag=pullrequest+performance+-needsrebase+-needswork&field.tags_combinator=ALL&field.omit_dupes=on|Efficiency / performance]]
+  * [[https://bugs.launchpad.net/evergreen/+bugs?orderby=-importance&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=DEFERRED&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&assignee_option=any&&field.tag=pullrequest+database+-needsrebase+-needswork&field.tags_combinator=ALL&field.omit_dupes=on|Database]]
+  * [[https://bugs.launchpad.net/evergreen/+bugs?orderby=-importance&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=DEFERRED&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&assignee_option=any&&field.tag=pullrequest+permissions+-needsrebase+-needswork&field.tags_combinator=ALL&field.omit_dupes=on|Permissions]]
+  * [[https://bugs.launchpad.net/evergreen/+bugs?orderby=-importance&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=DEFERRED&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&assignee_option=any&&field.tag=pullrequest+idl+-needsrebase+-needswork&field.tags_combinator=ALL&field.omit_dupes=on|IDL]]
+    * [[https://bugs.launchpad.net/evergreen/+bugs?orderby=-importance&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=DEFERRED&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&assignee_option=any&&field.tag=pullrequest+webstaffcolumns+-needsrebase+-needswork&field.tags_combinator=ALL&field.omit_dupes=on|Staff columns]] issues are usually IDL-related; otherwise grid
+  * [[https://bugs.launchpad.net/evergreen/+bugs?orderby=-importance&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=DEFERRED&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&assignee_option=any&&field.tag=pullrequest+eg-grid+-needsrebase+-needswork&field.tags_combinator=ALL&field.omit_dupes=on|Grid]]
+  * [[https://bugs.launchpad.net/evergreen/+bugs?orderby=-importance&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=DEFERRED&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&assignee_option=any&&field.tag=pullrequest+eg-combobox+-needsrebase+-needswork&field.tags_combinator=ALL&field.omit_dupes=on|Combobox]]
+  * [[https://bugs.launchpad.net/evergreen/+bugs?orderby=-importance&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=DEFERRED&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&assignee_option=any&&field.tag=pullrequest+accessibility+-needsrebase+-needswork&field.tags_combinator=ALL&field.omit_dupes=on|Accessibility]]
+    * [[https://bugs.launchpad.net/evergreen/+bugs?orderby=-importance&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=DEFERRED&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&assignee_option=any&&field.tag=pullrequest+accessibility+dark-mode+-opac+-needsrebase+-needswork&field.tags_combinator=ALL&field.omit_dupes=on|Staff + dark mode]]
+    * [[https://bugs.launchpad.net/evergreen/+bugs?orderby=-importance&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=DEFERRED&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&&field.tag=pullrequest+accessibility+-dark-mode+-ux-colors+-opac+-needsrebase+-needswork&field.tags_combinator=ALL&field.omit_dupes=on|Staff + everything else]]
+    * [[https://bugs.launchpad.net/evergreen/+bugs?orderby=-importance&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=DEFERRED&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&assignee_option=any&&field.tag=pullrequest+opac+accessibility+-needsrebase+-needswork&field.tags_combinator=ALL&field.omit_dupes=on|OPAC]]
+  * [[https://bugs.launchpad.net/evergreen/+bugs?orderby=-importance&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=DEFERRED&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&assignee_option=any&&field.tag=pullrequest+cleanup+-needsrebase+-needswork&field.tags_combinator=ALL&field.omit_dupes=on|Cleanup]]