**Code Review**
====== Meetings ======

Collaborative Code Review meets Mondays at 2pm Eastern.

  * **January 12, 2026**
    * [[https://bugs.launchpad.net/evergreen/+bug/2137020|#2137020]] In-query PCRUD permission testing can fail of classname is an SQL reserved word - //fix committed//
    * [[https://bugs.launchpad.net/evergreen/+bug/2133888|#2133888]] Values in Hold Details don't match between angularjs and angular - //fix committed//
    * [[https://bugs.launchpad.net/evergreen/+bug/2137671|#2137671]] OPAC: Basket counter is misleading on 'Place Hold' and "Add to my list" functions - //Working Branch Pushed//
  * **January 5, 2026**
    * [[https://bugs.launchpad.net/evergreen/+bug/1175400|#1175400]] ACQ: Possible to Over-allocate from a Funding Source - //Feedback Added//
    * [[https://bugs.launchpad.net/evergreen/+bug/2137020|#2137020]] In-query PCRUD permission testing can fail of classname is an SQL reserved word
    * [[https://bugs.launchpad.net/evergreen/+bug/2137056|#2137056]] Staff Portal Page - Open in New Tab still doesn't consistently work - //fix committed//
    * [[https://bugs.launchpad.net/evergreen/+bug/2137230|#2137230]] Record bucket edit has double arrows by Owning User - //fix committed//
    * [[https://bugs.launchpad.net/evergreen/+bug/2137146|#2137146]] Staff catalog record details - pagination buttons missing borders - //fix committed//
  * **December 15, 2025**
    * [[https://bugs.launchpad.net/evergreen/+bug/2037136|#2037136]] Course Materials: Deleted Items Included in Course List - //collab working branch created//
  * **December 8, 2025**
    * [[https://bugs.launchpad.net/evergreen/+bug/2101913|#2101913]] Angular Patron Search Form Defaults to Barcode Field (which is least likely field to be searched) - //fix committed//
    * [[https://bugs.launchpad.net/evergreen/+bug/2078503|#2078503]] acq: MARC federated search cannot use currency symbol in 020$c
    * [[https://bugs.launchpad.net/evergreen/+bug/1917761|#1917761]] Add Ability to View, Edit, Delete All Patron Barcodes
  * **December 1, 2025**
    * [[https://bugs.launchpad.net/evergreen/+bug/2026600|#2026600]] ACQ angular interface no longer show line item copy notes
    * [[https://bugs.launchpad.net/evergreen/+bug/2126602|#2126602]] Perl errors from background vandelay import
    * [[https://bugs.launchpad.net/evergreen/+bug/2115655|#2115655]] OPAC hold forms: ARIA for missing email warning
    * [[https://bugs.launchpad.net/evergreen/+bug/1868837|#1868837]] Hold targeter ignoring closed settings when only local copies
    * [[https://bugs.launchpad.net/evergreen/+bug/1835765|#1835765]] Illogical structure of items and tabs in my account preferences in OPAC //and// [[https://bugs.launchpad.net/evergreen/+bug/2097153|#2097153]] OPAC - Privacy Waiver/Allow Others to Use My Account Spacing Off - //fix committed//
  * **November 24, 2025**
    * [[https://bugs.launchpad.net/evergreen/+bug/2078503|#2078503]] acq: MARC federated search cannot use currency symbol in 020$c
    * [[https://bugs.launchpad.net/evergreen/+bug/1839883|#1839883]] change "request item" to "place hold" in Search for Copies by Barcode - //pullrequest//
    * [[https://bugs.launchpad.net/evergreen/+bug/2115659|#2115659]] OPAC place hold form: validation styles, ARIA for org selector - //signedoff//
    * [[https://bugs.launchpad.net/evergreen/+bug/2115525|#2115525]] account preferences: edit forms need label, ARIA corrections - //signedoff//
    * [[https://bugs.launchpad.net/evergreen/+bug/2115655|#2115655]] hold forms: ARIA for missing email warning - //signedoff//
  * **November 17, 2025**
    * [[https://bugs.launchpad.net/evergreen/+bug/2110907|#2110907]] Staff Portal Page - Everything Opens in a New Tab - //Fix Committed//
    * [[https://bugs.launchpad.net/evergreen/+bug/1839883|#1839883]] change "request item" to "place hold" in Search for Copies by Barcode - //Followup patch pushed - pullrequest//
    * [[https://bugs.launchpad.net/evergreen/+bug/2131031|#2131031]] Holdings Template Editor: Call Number Fields not available in Grid - //Fix Committed//
    * [[https://bugs.launchpad.net/evergreen/+bug/2107404|#2107404]] updating pickup library from "view holds" doesn't retarget hold - //Fix Committed//
    * [[https://bugs.launchpad.net/evergreen/+bug/2131151|#2131151]] Angular modal dialogs render with unnecessary empty space beneath the last control when content is short - //Fix Committed//
  * **November 10, 2025** - Hack-A-Way
  * **October 27, 2025**
    * [[https://bugs.launchpad.net/evergreen/+bug/1735857|#1735857]] Consider embedding Accessibility Metadata Project terms in public catalog - //Fix Committed//
    * [[https://bugs.launchpad.net/evergreen/+bug/2115443|#2115443]] OPAC basic search keyword input should not have autofocus - //Feedback Added//
    * [[https://bugs.launchpad.net/evergreen/+bug/2069451|#2069451]] Basic search results too verbose (OPAC) - //Fix Committed//
    * [[https://bugs.launchpad.net/evergreen/+bug/2129807|#2129807]] Github actions builds are failing, they need apt-get update - //Fix Committed//
  * **October 20, 2025**
    * [[https://bugs.launchpad.net/evergreen/+bug/1949222|#1949222]] Add To Basket not an option in Basket Actions from inside the bib record - //Fix Committed//
    * Getting the nightwatch e2e tests working again!
  * **October 13, 2025**
    * [[https://bugs.launchpad.net/evergreen/+bug/2119242|#2119242]] Batch user notes
  * **October 6, 2025**
    * [[https://bugs.launchpad.net/evergreen/+bug/2033101|#2033101]] Port View Hold Shelf / Clear Hold Shelf to Angular 
  * **September 29, 2025**
    * [[https://bugs.launchpad.net/evergreen/+bug/1175400|#1175400]] ACQ: Possible to Over-allocate from a Funding Source
  * **September 22, 2025**
    * [[https://bugs.launchpad.net/evergreen/+bug/2121886|#2121886]] SIP2 hold cancellations fail to return a success message when the cancellation is successful - //Fix Committed//
    * [[https://bugs.launchpad.net/evergreen/+bug/787162|#787162]] Admin interface for call number classes - //Feedback provided//
    * [[https://bugs.launchpad.net/evergreen/+bug/2002166|#2002166]] Void lost item billing refunds non-monetary options - //Tested, needs more testing// (there are a lot of billing scenarios to try)
  * **September 15, 2025**
    * [[https://bugs.launchpad.net/evergreen/+bug/1945366|#1945366]] Preferred name should be used as display name in browser tab - //Fix Committed//
    * [[https://bugs.launchpad.net/evergreen/+bug/2002166|#2002166]] Void lost item billing refunds non-monetary options
    * [[https://bugs.launchpad.net/evergreen/+bug/2122448|#2122448]] Clearing the shelving location in the holdings editor crashes the browser - //Feedback added//
    * [[https://bugs.launchpad.net/evergreen/+bug/2121886|#2121886]] SIP2 hold cancellations fail to return a success message when the cancellation is successful
  * **September 8, 2025**
    * [[https://bugs.launchpad.net/evergreen/+bug/1821093|#1821093]] Patron Self Registration form needs captcha
    * [[https://bugs.launchpad.net/evergreen/+bug/1770289|#1770289]] Wishlist: an acquisitions data dashboard
  * **September 1, 2025** - US Holiday - No Meeting  
  * **August 25, 2025**
    * i18n:
      * [[https://bugs.launchpad.net/evergreen/+bug/2042915|#2042915]] Column headers show as untranslated in Czech staff client [Basic admin component doesn't translate grid column headers] -- //**needs work**//
      * [[https://bugs.launchpad.net/evergreen/+bug/1884261|#1884261]] fm_IDL.xml needs cleanup [adding labels + oils_persist:i18n to text fields]
    * Dark Mode:
      * [[https://bugs.launchpad.net/evergreen/+bug/2097385|#2097385]] Dark Mode z39.50 'View MARC' modal contrast issues - //Fix Committed//
      * [[https://bugs.launchpad.net/evergreen/+bug/2107141|#2107141]] Dark mode with enhanced marc editor looks bad - //Fix Committed//
      * [[https://bugs.launchpad.net/evergreen/+bug/2093225|#2093225]] Dark Mode: Acq Worksheet Column Headers are Light Grey text on Light Grey Background - //Fix Committed//