====== 3.4 Feedback Fest #1 — 20 to 24 May 2019 ======

===== How to contribute to the feedback fest =====

The goal of the fest is to give feedback on each and every outstanding pull request. Feedback can take many forms, including:

  * rebasing older pull request branches against the current master
  * commenting on the bug and the proposed patches
  * deciding if the bug no longer applies
  * testing and signing off on the patches
  * writing automated test cases for pull requests that need them
  * writing human test plans
  * writing release notes entries

While some or many of the pull requests will hopefully get signed off and merged during the fest, the primary goal is advancing each and every pull request by providing feedback.

===== Results =====

During this Feedback Fest, a total of 55 bugs got substantive action and 18 of them got their patches committed.  The following folks participated:

  * John Amundson
  * Galen Charlton
  * Garry Collum
  * Dawn Dale
  * Bill Erickson
  * Lynn Floyd
  * Rogan Hamby
  * Kyle Huckins
  * Dan Pearl
  * Jane Sandberg
  * Ben Shum
  * Remington Steed
  * Jason Stephenson
  * Meg Stroup
  * Cesar Velez
  * Dan Wells

===== Open pull requests (without signoffs) as of 16 May 2019 =====

^ Bug # ^ Title ^ Comments ^
| #1068287 | [[https://bugs.launchpad.net/evergreen/+bug/1068287|proposal for new "pre-cat" EG permission]] | |
| #1133464 | [[https://bugs.launchpad.net/evergreen/+bug/1133464|Use cover image/blurb URL from field 856]] | |
| #1155706 | [[https://bugs.launchpad.net/evergreen/+bug/1155706|Avoid Internal Server Errors with Hold Count Calculation/Display]] | Rebase & signoff on Dyrcona's patch|
| #1325704 | [[https://bugs.launchpad.net/evergreen/+bug/1325704|Correction to long overdue documentation and settings]] | |
| #1329920 | [[https://bugs.launchpad.net/evergreen/+bug/1329920|Distribution Formulas do not display fund year in parenthesis]] | |
| #1335668 | [[https://bugs.launchpad.net/evergreen/+bug/1335668|Change functionality of the ACQ transfer fund action]] | |
| <del>#1340892</del> | <del>[[https://bugs.launchpad.net/evergreen/+bug/1340892|Easy to break marc templates in the config file]]</del> | updated status to fixed-released; this was ultimately resolved by OpenSRF changes |
| #1411819 | [[https://bugs.launchpad.net/evergreen/+bug/1411819|Allow patron renewal on max fines for some libraries, disallow it for others]] | |
| #1418694 | [[https://bugs.launchpad.net/evergreen/+bug/1418694|ACQ: Within Selection List, "Save Items to Selection List" moves, not copies, lineitem(s) to another selection list]] | |
| #1424815 | [[https://bugs.launchpad.net/evergreen/+bug/1424815|Wishlist: Add a “read more” feature to the OPAC bib record view for fields with lots of text]] | |
| #1441750 | [[https://bugs.launchpad.net/evergreen/+bug/1441750|Go to string_agg (again)]] | |
| #1444644 | [[https://bugs.launchpad.net/evergreen/+bug/1444644|Copy Import Development]] | |
| #1487123 | [[https://bugs.launchpad.net/evergreen/+bug/1487123|Docs: Use asciidoc attributes for upgrade docs to simplify updating]] | |
| #1511765 | [[https://bugs.launchpad.net/evergreen/+bug/1511765|Checking in migrated lost status copies and Lost/Long Overdue/Lost and Paid copies with no associated circ generates error when zero-balance lost OU setting is enabled]] | |
| #1528616 | [[https://bugs.launchpad.net/evergreen/+bug/1528616|staff login for selfcheck allows OPAC account access]] | This bug is only visible to members of the security team. |
| <del>#1538678</del> | <del>[[https://bugs.launchpad.net/evergreen/+bug/1538678|webclient: No warning prompt when leaving MARC editor without saving]]</del> | Fix committed. |
| #1552409 | [[https://bugs.launchpad.net/evergreen/+bug/1552409|Invent a page in the OPAC for redirection to referring URL based authentication on external services such as EBSCO]] | |
| #1559239 | [[https://bugs.launchpad.net/evergreen/+bug/1559239|XSS via window.opener]] | Signed off. This bug is only visible to members of the security team. |
| #1560805 | [[https://bugs.launchpad.net/evergreen/+bug/1560805|webclient: locale picker does not work well]] | |
| #1562061 | [[https://bugs.launchpad.net/evergreen/+bug/1562061|Marking a Long Overdue transaction Lost adds a second bill to the patron record]] | |
| #1616501 | [[https://bugs.launchpad.net/evergreen/+bug/1616501|Stop waiting for method response when browser disconnects]] | |
| #1622358 | [[https://bugs.launchpad.net/evergreen/+bug/1622358|Keyboard shortcuts in the Web staff client not noted within menus]] | Removed pullrequest tag, added needsdiscussion tag |
| #1634244 | [[https://bugs.launchpad.net/evergreen/+bug/1634244|ACQ: deleting bib records does not check active/pending orders]] | |
| <del>#1642337</del> | <del>[[https://bugs.launchpad.net/evergreen/+bug/1642337|Web Staff Client - Boolean Filters in Reporter]]</del> | committed |
| #1657171 | [[https://bugs.launchpad.net/evergreen/+bug/1657171|ASCII apostrophe and Unicode right single quotation mark should be normalized]] | signed-off |
| <del>#1669120</del> | <del>[[https://bugs.launchpad.net/evergreen/+bug/1669120|Web Client: Unnecessary scrolling required in some dropdowns]]</del> | Fix committed |
| #1672346 | [[https://bugs.launchpad.net/evergreen/+bug/1672346|Wishlist: Reporter Copy Statistics View]] | |
| #1674364 | [[https://bugs.launchpad.net/evergreen/+bug/1674364|html item feeds - cover art lookup based off of ISBN]] | |
| #1681930 | [[https://bugs.launchpad.net/evergreen/+bug/1681930|fm_IDL reporter::xact_billing_totals incorrect column type]] | signed-off |
| #1683385 | [[https://bugs.launchpad.net/evergreen/+bug/1683385|Webstaff grid could be smarter in IDL mode]] | signed off |
| <del>#1693580</del> | <del>[[https://bugs.launchpad.net/evergreen/+bug/1693580|web client: attempting to update a MARC record without required permissions fails without feedback to the user]]</del> | committed |
| <del>#1704819</del> | <del>[[https://bugs.launchpad.net/evergreen/+bug/1704819|Fine generator can generate overdue fines beyond max-fine amount (rounding error)]]</del> | committed |
| #1710293 | [[https://bugs.launchpad.net/evergreen/+bug/1710293|Remaining chunk/bundle work]] | |
| #1711128 | [[https://bugs.launchpad.net/evergreen/+bug/1711128|OverDrive API display of Always Available Titles]] | |
| #1712644 | [[https://bugs.launchpad.net/evergreen/+bug/1712644|Web Client: Can Check Out with Due Date in the Past]] | signed off |
| #1713138 | [[https://bugs.launchpad.net/evergreen/+bug/1713138|EDIReader unable to extract some vendcodes]] | |
| #1715396 | [[https://bugs.launchpad.net/evergreen/+bug/1715396|auth_proxy, native login fails when LDAP unavailable]] | |
| #1717366 | [[https://bugs.launchpad.net/evergreen/+bug/1717366|Web client-  LSE Toggle off the patron summary sidebar after first view]] | |
| #1717996 | [[https://bugs.launchpad.net/evergreen/+bug/1717996|web client: better label for 'publicly visible' buckets]] | signed off |
| #1721036 | [[https://bugs.launchpad.net/evergreen/+bug/1721036|Add the ability for copy tags to be links]] | |
| #1728331 | [[https://bugs.launchpad.net/evergreen/+bug/1728331|It's difficult to pull a single day's events with action_trigger_aggregator.pl]] | |
| #1729435 | [[https://bugs.launchpad.net/evergreen/+bug/1729435|Web Client: Bill Full Details - can't save column configuration]] | |
| #1729889 | [[https://bugs.launchpad.net/evergreen/+bug/1729889|Looks like an MD5 hash of a password field is being displayed in record holds grid]] | |
| #1731021 | [[https://bugs.launchpad.net/evergreen/+bug/1731021|Enhance SIP support for fine item detail]] | |
| #1731370 | [[https://bugs.launchpad.net/evergreen/+bug/1731370|Webstaff UI issue in the volume/copy editor]] | |
| <del>#1735754</del> | <del>[[https://bugs.launchpad.net/evergreen/+bug/1735754|The advanced search screen uses HTML valign attribute to format content]]</del> | committed |
| #1735768 | [[https://bugs.launchpad.net/evergreen/+bug/1735768|input fields in the public catalog often have no description]] | |
| #1735847 | [[https://bugs.launchpad.net/evergreen/+bug/1735847|Default hold transit slip should not include patron information]] | signed off |
| #1736967 | [[https://bugs.launchpad.net/evergreen/+bug/1736967|don't use primary for "a" css styling]] |signed-off |
| #1738238 | [[https://bugs.launchpad.net/evergreen/+bug/1738238|Hatch docs: Support Fedora workstations]] | discussed and pullrequest removed |
| #1741980 | [[https://bugs.launchpad.net/evergreen/+bug/1741980|Copy Tag names not displayed in OPAC]] | feedback given |
| #1741997 | [[https://bugs.launchpad.net/evergreen/+bug/1741997|additional browse improvements]] | |
| #1742523 | [[https://bugs.launchpad.net/evergreen/+bug/1742523|Web Client: The Mark Damaged Popup has untranslateable strings]] | |
| #1744341 | [[https://bugs.launchpad.net/evergreen/+bug/1744341|Long-frozen holds skew hold queue position calculation]] | |
| #1744762 | [[https://bugs.launchpad.net/evergreen/+bug/1744762|Lineitems by Bib only supports filtering a single state]] | |
| #1747542 | [[https://bugs.launchpad.net/evergreen/+bug/1747542|Circulation limit set test is not accounting for lost/longoverdue and paid items]] | |
| #1748265 | [[https://bugs.launchpad.net/evergreen/+bug/1748265|SMS Carrier not available as a column option in the web client]] | signed off |
| #1748277 | [[https://bugs.launchpad.net/evergreen/+bug/1748277|Patron Registration long Field Documentation display issue]] | rebased patch |
| #1751800 | [[https://bugs.launchpad.net/evergreen/+bug/1751800|web client: reports - column labels spontaneously re-sort when deleting template fields]] | |
| #1752334 | [[https://bugs.launchpad.net/evergreen/+bug/1752334|OpenILS::Utils::BadContact->mark_users_contact_invalid ignores additional note argument]] | |
| #1754110 | [[https://bugs.launchpad.net/evergreen/+bug/1754110|Wishlist: Patron Reg.  Field Label Override]] | |
| #1756142 | [[https://bugs.launchpad.net/evergreen/+bug/1756142|Failure to display large report schedule/template folders]] | |
| #1756564 | [[https://bugs.launchpad.net/evergreen/+bug/1756564|Wishlist: add booking resource types and resources to concerto data set]] | |
| #1759864 | [[https://bugs.launchpad.net/evergreen/+bug/1759864|Mark Item Damaged from Holding View Fails]] | |
| <del>#7608931</del> | <del>[[https://bugs.launchpad.net/evergreen/+bug/1760893|webclient: add volume - parts order]]</del> | committed |
| #1761142 | [[https://bugs.launchpad.net/evergreen/+bug/1761142|Volume Copy Editor Changed Fields Hard to Discern]] | |
| #1761222 | [[https://bugs.launchpad.net/evergreen/+bug/1761222|Web Client: More Options needed for Holdings View Column Picker]] | |
| #1765434 | [[https://bugs.launchpad.net/evergreen/+bug/1765434|Web client purchase order, browser refresh closes the purchase order]] | |
| #1768022 | [[https://bugs.launchpad.net/evergreen/+bug/1768022|Webclient Holds Pull List Returns 0 Results]] | |
| #1768869 | [[https://bugs.launchpad.net/evergreen/+bug/1768869|Keeping auditor tables up to date after source tables change]] | |
| <del>#1768987</del> | <del>[[https://bugs.launchpad.net/evergreen/+bug/1768987|24-sql-gettext-unique.t will fail if not run from perlmods directory.]]</del> | committed |
| #1770212 | [[https://bugs.launchpad.net/evergreen/+bug/1770212|webstaff: EXPAND_WEB_IMPORTS = 0 no longer works]] | |
| <del>#1772028</del> | <del>[[https://bugs.launchpad.net/evergreen/+bug/1772028|Missing db functions in 3.0.1-3.0.2 upgrade script]]</del> | committed |
| #1772680 | [[https://bugs.launchpad.net/evergreen/+bug/1772680|RBdigital integration]] | |
| <del>#1774707</del> | <del>[[https://bugs.launchpad.net/evergreen/+bug/1774707|Columns don't save on patron's Group Member Details grid]]</del> | committed |
| <del>#1775639</del> | <del>[[https://bugs.launchpad.net/evergreen/+bug/1775639|webclient: Refresh required to see Patron Credit]]</del> | committed |
| #1775870 | [[https://bugs.launchpad.net/evergreen/+bug/1775870|Web client - random sort order of spine labels in preview & printed out]] | tested and signed off |
| #1775920 | [[https://bugs.launchpad.net/evergreen/+bug/1775920|Web Client: Item Status Detail View Missing "Show" Actions]] | |
| #1776003 | [[https://bugs.launchpad.net/evergreen/+bug/1776003| The 007 Physical Characteristics Wizard should list characters as well as descriptions in the dropdown menus]] | signed off and added follow-up patch |
| #1776913 | [[https://bugs.launchpad.net/evergreen/+bug/1776913|Rename menu item "Circ Limit Sets" to "Circulation Limit Sets" under Local Admin]] | signed off |
| #1776954 | [[https://bugs.launchpad.net/evergreen/+bug/1776954|Zotero fails to capture metadata]] | |
| #1778063 | [[https://bugs.launchpad.net/evergreen/+bug/1778063|Web client forms need autocomplete and autocapitalize attributes]] | |
| #1778414 | [[https://bugs.launchpad.net/evergreen/+bug/1778414|The catalog menu should include Item Status]] | signoff + discussion |
| #1778712 | [[https://bugs.launchpad.net/evergreen/+bug/1778712|Docs: Replace screenshots in "Circulating Items" chapter]] | feedback given |
| #1778783 | [[https://bugs.launchpad.net/evergreen/+bug/1778783|open-ils.circ.checkout.full log_me() uses legacy arg for copy barcode]] | |
| #1778955 | [[https://bugs.launchpad.net/evergreen/+bug/1778955|Use builtin array_remove() function rather than our custom version]] | testing feedback |
| #1779319 | [[https://bugs.launchpad.net/evergreen/+bug/1779319|Add ISBN subfield q to record summary.]] | |
| #1785061 | [[https://bugs.launchpad.net/evergreen/+bug/1785061|web client reporter: can't hard code a list of filter values]] | signed off |
| #1786552 | [[https://bugs.launchpad.net/evergreen/+bug/1786552|LDAP: Bind user option]] | |
| #1788260 | [[https://bugs.launchpad.net/evergreen/+bug/1788260|reporter: action.all_circulations_combined_types should break out non-cat in-house-use ]] | |
| #1788485 | [[https://bugs.launchpad.net/evergreen/+bug/1788485|Batch Actions: issues with basket actions]] | |
| #1789679 | [[https://bugs.launchpad.net/evergreen/+bug/1789679|Supply subtotal and grand total rows in reports that use aggregate functions]] | gave feedback |
| #1790231 | [[https://bugs.launchpad.net/evergreen/+bug/1790231|Subject heading link includes non-exact matches]] | |
| #1794884 | [[https://bugs.launchpad.net/evergreen/+bug/1794884|SRU/Z39.50 results can include non-OPAC-visible holdings]] | |
| #1795906 | [[https://bugs.launchpad.net/evergreen/+bug/1795906|Bring parity to the estimated queue position in OPAC and Record -> View Holds UIs]] | |
| #1795937 | [[https://bugs.launchpad.net/evergreen/+bug/1795937|Replace favicon with new logo]] | |
| #1796903 | [[https://bugs.launchpad.net/evergreen/+bug/1796903|Make the angularjs date picker calendar button more accessible]] | gave feedback |
| #1796914 | [[https://bugs.launchpad.net/evergreen/+bug/1796914|The menu in top right corner of Web client should have a name]] | signed off |
| #1796936 | [[https://bugs.launchpad.net/evergreen/+bug/1796936|eg-grid row selection checkboxes should have aria-labels]] | |
| <del>#1796942</del> | <del>[[https://bugs.launchpad.net/evergreen/+bug/1796942|SIP2 payments with payment type 01 ("VISA") are recorded as cash]]</del> | committed |
| #1796945 | [[https://bugs.launchpad.net/evergreen/+bug/1796945|Report templates cloned from those created on XUL client causing error or  producing different results]] | |
| #1797973 | [[https://bugs.launchpad.net/evergreen/+bug/1797973|Webstaff - eg-org-selector directive's input will stretch to fill page width]] | |
| #1798187 | [[https://bugs.launchpad.net/evergreen/+bug/1798187|Item status -- Barcodes with initial or trailing spaces fail silently when in txt file]] | signed off |
| #1799272 | [[https://bugs.launchpad.net/evergreen/+bug/1799272|SIP2 Hold Items Count Includes Unavailable Holds]] | left feedback |
| #1800484 | [[https://bugs.launchpad.net/evergreen/+bug/1800484|Money summary is missing on user Bills tab when no transactions are open]] | |
| #1800871 | [[https://bugs.launchpad.net/evergreen/+bug/1800871|MARC21slim2MADS.xsl error processing 755 source]] | |
| #1801163 | [[https://bugs.launchpad.net/evergreen/+bug/1801163|SendEmail A/T reactor broken for recent version of Encode::MIME::Header]] | |
| #1802166 | [[https://bugs.launchpad.net/evergreen/+bug/1802166|Preferred Name and Keywords Stay After Purging Patron]] | |
| #1802593 | [[https://bugs.launchpad.net/evergreen/+bug/1802593|AngularJS web client has invalid lang attributes]] | |
| #1802682 | [[https://bugs.launchpad.net/evergreen/+bug/1802682|web client doesn't respect Default Net Access Level OUS]] | |
| #1802952 | [[https://bugs.launchpad.net/evergreen/+bug/1802952|Auto suggest not accounting for located URI (electronic) record visibility]] | |
| #1803584 | [[https://bugs.launchpad.net/evergreen/+bug/1803584|Clear button does not work for Holdings Template Editor]] | |
| #1803787 | [[https://bugs.launchpad.net/evergreen/+bug/1803787|new Angular eg-grid doesn't include right click Actions menu]] | |
| #1803790 | [[https://bugs.launchpad.net/evergreen/+bug/1803790|Re-alphabetize Local & Server Administration links]] | |
| #1806783 | [[https://bugs.launchpad.net/evergreen/+bug/1806783|Offline: Non-cataloged types do not print description]] | |
| #1807998 | [[https://bugs.launchpad.net/evergreen/+bug/1807998|seed data for Currency Types has wrong code for Canadian Dollars]] | Added new comment, removed tag pullrequest, added tag needsrepatch |
| #1810296 | [[https://bugs.launchpad.net/evergreen/+bug/1810296|Selfcheck:  require password setting is ignored if set to "False"]] | |
| #1811132 | [[https://bugs.launchpad.net/evergreen/+bug/1811132|Wishlist - New Payment Type "Debit" ]] | |
| #1811696 | [[https://bugs.launchpad.net/evergreen/+bug/1811696|Add option to rebuild reporter.materialized_simple_record to pingest.pl]] | |
| #1811898 | [[https://bugs.launchpad.net/evergreen/+bug/1811898|DDC call numbers with long subdivisions not printing correctly]] | |
| #1812241 | [[https://bugs.launchpad.net/evergreen/+bug/1812241|YAOUS for when no 856$z is present]] | signed off |
| #1812900 | [[https://bugs.launchpad.net/evergreen/+bug/1812900|Workstation setting cat.copy.defaults not sticky]] | signed off |
| #1813191 | [[https://bugs.launchpad.net/evergreen/+bug/1813191|Move calculated dewey ranges/blocks to their own reporting view]] | |
| #1813225 | [[https://bugs.launchpad.net/evergreen/+bug/1813225|Link Billing Location to Library Information page]] | signed off |
| #1815229 | [[https://bugs.launchpad.net/evergreen/+bug/1815229|auth_proxy should have a "bail on fail" option]] | feedback given |
| <del>#1816480</del> | <del>[[https://bugs.launchpad.net/evergreen/+bug/1816480|Angular and Angularjs grids should adhere to WAI-ARIA Authoring Practices for grids as much as possible]]</del> | committed |
| <del>#1816679</del> | <del>[[https://bugs.launchpad.net/evergreen/+bug/1816679|Supply select values for "Match Set Type" in new Angular Vandelay]]</del> | committed |
| <del>#1817332</del> | <del>[[https://bugs.launchpad.net/evergreen/+bug/1817332|Document examples of valid lib.timezone setting values]]</del> | committed |
| <del>#1817601</del> | <del>[[https://bugs.launchpad.net/evergreen/+bug/1817601|MARC Flat Text Editor should also use fixed-width font]]</del> | committed |
| #1817645 | [[https://bugs.launchpad.net/evergreen/+bug/1817645|Configurable patron auth and retrieval]] | |
| #1817932 | [[https://bugs.launchpad.net/evergreen/+bug/1817932|Update Hatch Java / Javafx versions]] | |
| #1818581 | [[https://bugs.launchpad.net/evergreen/+bug/1818581|Action Trigger for Fine Limit Exceeded]] | |
| <del>#1819181</del> | <del>[[https://bugs.launchpad.net/evergreen/+bug/1819181|Can't set an Example for Date of Birth in Patron Registration]]</del> | committed |
| #1819540 | [[https://bugs.launchpad.net/evergreen/+bug/1819540|Web client: Show Clearable holds list shows holds that  can not be Cleared with the "Clear these holds" process. ]] | |
| #1821032 | [[https://bugs.launchpad.net/evergreen/+bug/1821032|compare_array implementation is confusing]] | |
| #1821094 | [[https://bugs.launchpad.net/evergreen/+bug/1821094|Item status refresh after editing can get confusingly slow]] | substantial testing |
| #1822414 | [[https://bugs.launchpad.net/evergreen/+bug/1822414|The Angular datepicker in the fmeditor does not go into read-only mode]] | |
| #1822630 | [[https://bugs.launchpad.net/evergreen/+bug/1822630|OPAC is vulnerable to Cross-site scripting attacks.]] | |
| #1823041 | [[https://bugs.launchpad.net/evergreen/+bug/1823041|Angular dialogs should limit promise rejections to error conditions]] | |
| #1823255 | [[https://bugs.launchpad.net/evergreen/+bug/1823255|Optionally require ident_value]] | need for DCO noted |
| <del>#1823393</del> | <del>[[https://bugs.launchpad.net/evergreen/+bug/1823393|Port Org Unit Type editor to Angular / FM Editor Translate Buttons]]</del> | committed |
| #1823981 | [[https://bugs.launchpad.net/evergreen/+bug/1823981|Port Permission Group Admin Page to Angular]] | |
| #1823983 | [[https://bugs.launchpad.net/evergreen/+bug/1823983|Action triggers repeat_delay looking at unrelated events]] | |
| #1824391 | [[https://bugs.launchpad.net/evergreen/+bug/1824391|Hatch native print-to-file support]] | |
| #1825851 | [[https://bugs.launchpad.net/evergreen/+bug/1825851|Server-generated print templates]] | feedback given |
| #1825896 | [[https://bugs.launchpad.net/evergreen/+bug/1825896|EG/Hatch options for improved browser data-clearing resiliency]] | |
| #1826584 | [[https://bugs.launchpad.net/evergreen/+bug/1826584|continue past alert and confirm dialogs with keyboard space or enter]] | feedback + follow-up patches |
| #1827250 | [[https://bugs.launchpad.net/evergreen/+bug/1827250|Holds not displaying in web client Holds Shelf]] | use in production noted |
| #1828456 | [[https://bugs.launchpad.net/evergreen/+bug/1828456|AuthProxy native login fails if username begins with a number]] | |