**New Developers Working Group** ===== Meeting Agenda: November 20, 2019, 3pm ET ===== **Testing and Signoffs** This week we will review some patches that have been submitted to launchpad and have the pullrequest tag. We will test and then walk through the process of doing a signoff using git bash. **Patches** * [[https://bugs.launchpad.net/evergreen/+bug/1712861|1712861 - Holds column for notices]] * Note from Blake: Caused a Perl compilation error, could not apply * [[https://bugs.launchpad.net/evergreen/+bug/1712644|1712644 - Prevent checking out with due date in the past]] * We tested this as a group and signed off. * [[https://bugs.launchpad.net/evergreen/+bug/1835982|1835982 - Angular: Grid cells that use a cellTemplate aren't included in CSV or Print]] * Note from Blake: Caused errors, could not apply * [[https://bugs.launchpad.net/evergreen/+bug/1830089|1830089 - Adjust to Zero does not set item to Lost and Paid]] * We tested this as a group and signed off. * [[https://bugs.launchpad.net/evergreen/+bug/1717366|1717366 - Library Setting for toggling patron summary after first view]] * Note from Blake: Needs rebase * [[https://bugs.launchpad.net/evergreen/+bug/1705302|1705302 - Descriptions of print template includes]] * We tested this as a group and it works, but HTML and Macros no longer work in the web client so we added a "needsrepatch" tag and requested the change. * [[https://bugs.launchpad.net/evergreen/+bug/1787415|1787415 - Most recent circ group inconsistently displayed]] * Unable to successfully test. * [[https://bugs.launchpad.net/evergreen/+bug/1748277|1748277 - Patron field documentation display issues]] * Unable to successfully test. * [[https://bugs.launchpad.net/evergreen/+bug/1674364|1674364 - News feed cover image lookup]] * Unable to successfully test. * [[https://bugs.launchpad.net/evergreen/+bug/1851541|1851541 - Item alert sound]] * Tested and signed off by Terran. **Sandbox** * [[https://bugsquash.mobiusconsortium.org|OPAC]] * [[https://bugsquash.mobiusconsortium.org/eg/staff/|Staff Client]] * admin / demo123 * Thank you to Blake for setting up the sandbox for us!