Code Review

Meetings

Collaborative Code Review meets Mondays at 2pm Eastern.

January 5, 2025
- #2137020 In-query PCRUD permission testing can fail of classname is an SQL reserved word
- #2137056 Staff Portal Page - Open in New Tab still doesn't consistently work
- #2137230 Record bucket edit has double arrows by Owning User
- #2137146 Staff catalog record details - pagination buttons missing borders
December 15, 2025
- #2037136 Course Materials: Deleted Items Included in Course List - collab working branch created
December 8, 2025
- #2101913 Angular Patron Search Form Defaults to Barcode Field (which is least likely field to be searched) - fix committed
- #2078503 acq: MARC federated search cannot use currency symbol in 020$c
- #1917761 Add Ability to View, Edit, Delete All Patron Barcodes
December 1, 2025
- #2026600 ACQ angular interface no longer show line item copy notes
- #2126602 Perl errors from background vandelay import
- #2115655 OPAC hold forms: ARIA for missing email warning
- #1868837 Hold targeter ignoring closed settings when only local copies
- #1835765 Illogical structure of items and tabs in my account preferences in OPAC and #2097153 OPAC - Privacy Waiver/Allow Others to Use My Account Spacing Off - fix committed
November 24, 2025
- #2078503 acq: MARC federated search cannot use currency symbol in 020$c
- #1839883 change "request item" to "place hold" in Search for Copies by Barcode - pullrequest
- #2115659 OPAC place hold form: validation styles, ARIA for org selector - signedoff
- #2115525 account preferences: edit forms need label, ARIA corrections - signedoff
- #2115655 hold forms: ARIA for missing email warning - signedoff
November 17, 2025
- #2110907 Staff Portal Page - Everything Opens in a New Tab - Fix Committed
- #1839883 change "request item" to "place hold" in Search for Copies by Barcode - Followup patch pushed - pullrequest
- #2131031 Holdings Template Editor: Call Number Fields not available in Grid - Fix Committed
- #2107404 updating pickup library from "view holds" doesn't retarget hold - Fix Committed
- #2131151 Angular modal dialogs render with unnecessary empty space beneath the last control when content is short - Fix Committed
November 10, 2025 - Hack-A-Way
October 27, 2025
- #1735857 Consider embedding Accessibility Metadata Project terms in public catalog - Fix Committed
- #2115443 OPAC basic search keyword input should not have autofocus - Feedback Added
- #2069451 Basic search results too verbose (OPAC) - Fix Committed
- #2129807 Github actions builds are failing, they need apt-get update - Fix Committed
October 20, 2025
- #1949222 Add To Basket not an option in Basket Actions from inside the bib record - Fix Committed
- Getting the nightwatch e2e tests working again!
October 13, 2025
- #2119242 Batch user notes
October 6, 2025
- #2033101 Port View Hold Shelf / Clear Hold Shelf to Angular
September 29, 2025
- #1175400 ACQ: Possible to Over-allocate from a Funding Source
September 22, 2025
- #2121886 SIP2 hold cancellations fail to return a success message when the cancellation is successful - Fix Committed
- #787162 Admin interface for call number classes - Feedback provided
- #2002166 Void lost item billing refunds non-monetary options - Tested, needs more testing (there are a lot of billing scenarios to try)
September 15, 2025
- #1945366 Preferred name should be used as display name in browser tab - Fix Committed
- #2002166 Void lost item billing refunds non-monetary options
- #2122448 Clearing the shelving location in the holdings editor crashes the browser - Feedback added
- #2121886 SIP2 hold cancellations fail to return a success message when the cancellation is successful
September 8, 2025
- #1821093 Patron Self Registration form needs captcha
- #1770289 Wishlist: an acquisitions data dashboard
September 1, 2025 - US Holiday - No Meeting
August 25, 2025
- i18n:
  - #2042915 Column headers show as untranslated in Czech staff client [Basic admin component doesn't translate grid column headers] – needs work
  - #1884261 fm_IDL.xml needs cleanup [adding labels + oils_persist:i18n to text fields]
- Dark Mode:
  - #2097385 Dark Mode z39.50 'View MARC' modal contrast issues - Fix Committed
  - #2107141 Dark mode with enhanced marc editor looks bad - Fix Committed
  - #2093225 Dark Mode: Acq Worksheet Column Headers are Light Grey text on Light Grey Background - Fix Committed