dev:signoff_review_checklist
This is an old revision of the document!
Signoff / review checklist
Yes/No | Item |
---|---|
Have you run make check with zero failed tests? |
|
Does this commit have an associated release notes entry, if applicable? New features, new config.tt2 entries, new user or org unit settings, changes in behaviour should have a release notes entry. | |
Have you tested normal Evergreen functionality before and after the commit to ensure that it remains the same (or changes only in the way that the commit describes it should)? | |
If the commit adds new text, has it been added using the appropriate translation infrastructure? Please avoid constructed sentences. | |
Do the changes introduce any accessibility problems? Examples include using images of text instead of actual text; failure to use ALT tags for significant images; use of tables for layout instead of for tabular data… | |
Does the change introduce a new dependency; if so, has that dependency been covered in Makefile.install, and called out in the Release Notes, and a heads-up given to the broader community of testers / fellow developers / distro maintainers? | |
If there is a schema change, has the upgrade SQL script been generated with the correct update ID #, and does it match the number for config.upgrade_log in Open-ILS/src/sql/Pg/002.schema.config.sql ? |
|
Do all of the commits have commit messages with a) short first line summary; b) a description with lines less than 72 chars wide; c) Signed-off by line indicating DCO compliance; d) appropriate Author credit? |
|
If third-party code is being integrated in the codebase, does it fall under a license compliant with ours (GPL v2, with the "or later" clause)? | |
(Docs) Do a2x –format epub root.txt , a2x –format pdf root.txt , and asciidoc root.txt all return cleanly? |
dev/signoff_review_checklist.1355754333.txt.gz · Last modified: 2022/02/10 13:34 (external edit)