Differences

This shows you the differences between two versions of the page.

--- dev:proposal:patron_statistical_categories [2012/01/17 09:26] – [Requirements] sprater
+++ dev:proposal:patron_statistical_categories [2022/02/10 13:34] (current) – external edit 127.0.0.1
@@ Line 35: / Line 35: @@
 === Patron Registration Screen ===
-  * In patron registration, if the statistical category is required, do not allow the user to save the record if no default entry has been set AND no entry has been selected or no free text has been entered.
+  * When registering a new patron or updating the record for an existing one, if the statistical category is required, do not allow the user to save the record if no default entry has been set AND no entry has been selected or no free text has been entered.
-  * In patron registration, do not allow the user to enter text if the statistical category is set up to not allow user-entered text.
+  * When registering a new patron or updating the record for an existing one, do not allow the user to enter text if the statistical category is set up to not allow user-entered text.
-  * In patron registration, display a default value in the statistical category if a default entry has been configured in the entry list.  Allow the user to save the record if the user makes no change to the field;  the value of the statistical category will be the default entry.
+  * When registering a new patron, display a default value in the statistical category form field if a default entry has been configured in the entry list for the org unit or an ancestor org unit.  Allow the user to save the record if the no change is made to the field;  the value of the statistical category will be the default entry.  When updating existing patrons, no default value will be supplied:  the value of the form field will either be the previously-saved value or empty.
 ===== Objects Affected =====
-All modified files are available at [[https://github.com/sprater/Evergreen/tree/patcatstat|https://github.com/sprater/Evergreen/tree/patcatstat]].
+All modified files are available at [[https://github.com/sprater/Evergreen/tree/patstatcat|https://github.com/sprater/Evergreen/tree/patstatcat]].
-Comparisons:  [[https://github.com/sprater/Evergreen/compare/patcatstat|https://github.com/sprater/Evergreen/compare/patcatstat]]
+Comparisons:  [[https://github.com/sprater/Evergreen/compare/patstatcat|https://github.com/sprater/Evergreen/compare/patstatcat]]
 **Database TABLE ''actor.stat_cat''**
@@ Line 53: / Line 53: @@
         id              SERIAL  PRIMARY KEY,
-        stat_cat_entry  INT     NOT NULL references actor.stat_cat_entry,
+        stat_cat_entry  INT     NOT NULL REFERENCES actor.stat_cat_entry(id) ON DELETE CASCADE DEFERRABLE INITIALLY DEFERRED,
-        stat_cat        INT     NOT NULL references actor.stat_cat,
+        stat_cat        INT     NOT NULL REFERENCES actor.stat_cat(id) ON DELETE CASCADE DEFERRABLE INITIALLY DEFERRED,
-        org_unit        INT     NOT NULL references actor.org_unit,
+        owner           INT     NOT NULL REFERENCES actor.org_unit(id) ON DELETE CASCADE DEFERRABLE INITIALLY DEFERRED,
-        CONSTRAINT sced_once_per_org_unit UNIQUE (stat_cat,org_unit)
+        CONSTRAINT sced_once_per_owner UNIQUE (stat_cat,owner)
-See [[https://github.com/sprater/Evergreen/blob/patcatstat/Open-ILS/src/sql/Pg/005.schema.actors.sql|005.schema.actors.sql]], [[https://github.com/sprater/Evergreen/blob/patcatstat/Open-ILS/src/sql/Pg/800.fkeys.sql|800.fkeys.sql]] and [[https://github.com/sprater/Evergreen/blob/patcatstat/Open-ILS/src/sql/Pg/950.data.seed-values.sql|950.data.seed-values.sql]].
+See [[https://github.com/sprater/Evergreen/blob/patstatcat/Open-ILS/src/sql/Pg/005.schema.actors.sql|005.schema.actors.sql]] and [[https://github.com/sprater/Evergreen/blob/patstatcat/Open-ILS/src/sql/Pg/950.data.seed-values.sql|950.data.seed-values.sql]].
 **Statistical category editor**
   * Add code to manage the new fields in **actor.stat_cat** and the new table **actor.stat_cat_entry_default**.
 See
-  * [[https://github.com/sprater/Evergreen/blob/patcatstat/Open-ILS/examples/fm_IDL.xml|Open-ILS/examples/fm_IDL.xml]]
+  * [[https://github.com/sprater/Evergreen/blob/patstatcat/Open-ILS/examples/fm_IDL.xml|Open-ILS/examples/fm_IDL.xml]]
-  * [[https://github.com/sprater/Evergreen/blob/patcatstat/Open-ILS/src/extras/ils_events.xml|Open-ILS/src/extras/ils_events.xml]]
+  * [[https://github.com/sprater/Evergreen/blob/patstatcat/Open-ILS/src/extras/ils_events.xml|Open-ILS/src/extras/ils_events.xml]]
-  * [[https://github.com/sprater/Evergreen/blob/patcatstat/Open-ILS/src/perlmods/lib/OpenILS/Application/AppUtils.pm|Open-ILS/src/perlmods/lib/OpenILS/Application/AppUtils.pm]]
+  * [[https://github.com/sprater/Evergreen/blob/patstatcat/Open-ILS/src/perlmods/lib/OpenILS/Application/AppUtils.pm|Open-ILS/src/perlmods/lib/OpenILS/Application/AppUtils.pm]]
-  * [[https://github.com/sprater/Evergreen/blob/patcatstat/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/StatCat.pm|Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/StatCat.pm]]
+  * [[https://github.com/sprater/Evergreen/blob/patstatcat/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/StatCat.pm|Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/StatCat.pm]]
-  * [[https://github.com/sprater/Evergreen/blob/patcatstat/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/CDBI.pm|Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/CDBI.pm]]
+  * [[https://github.com/sprater/Evergreen/blob/patstatcat/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/CDBI.pm|Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/CDBI.pm]]
-  * [[https://github.com/sprater/Evergreen/blob/patcatstat/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/CDBI/actor.pm|Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/CDBI/actor.pm]]
+  * [[https://github.com/sprater/Evergreen/blob/patstatcat/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/CDBI/actor.pm|Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/CDBI/actor.pm]]
-  * [[https://github.com/sprater/Evergreen/blob/patcatstat/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/dbi.pm|Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/dbi.pm]]
+  * [[https://github.com/sprater/Evergreen/blob/patstatcat/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/dbi.pm|Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/dbi.pm]]
-  * [[https://github.com/sprater/Evergreen/blob/patcatstat/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/actor.pm|Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/actor.pm]]
+  * [[https://github.com/sprater/Evergreen/blob/patstatcat/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/actor.pm|Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/actor.pm]]
-  * [[https://github.com/sprater/Evergreen/blob/patcatstat/Open-ILS/web/opac/locale/en-US/lang.dtd|Open-ILS/web/opac/locale/en-US/lang.dtd]]
+  * [[https://github.com/sprater/Evergreen/blob/patstatcat/Open-ILS/web/opac/locale/en-US/lang.dtd|Open-ILS/web/opac/locale/en-US/lang.dtd]]
-  * [[https://github.com/sprater/Evergreen/blob/patcatstat/Open-ILS/xul/staff_client/server/admin/stat_cat_editor.xhtml|Open-ILS/xul/staff_client/server/admin/stat_cat_editor.xhtml]]
+  * [[https://github.com/sprater/Evergreen/blob/patstatcat/Open-ILS/xul/staff_client/server/admin/stat_cat_editor.xhtml|Open-ILS/xul/staff_client/server/admin/stat_cat_editor.xhtml]]
-  * [[https://github.com/sprater/Evergreen/blob/patcatstat/Open-ILS/xul/staff_client/server/admin/stat_cat_editor.js|Open-ILS/xul/staff_client/server/admin/stat_cat_editor.js]]
+  * [[https://github.com/sprater/Evergreen/blob/patstatcat/Open-ILS/xul/staff_client/server/admin/stat_cat_editor.js|Open-ILS/xul/staff_client/server/admin/stat_cat_editor.js]]
 **Patron registration**
@@ Line 81: / Line 81: @@
   * If a default entry is specified for the org unit and statistical category, mark it as selected by default.
-See
+See [[https://github.com/sprater/Evergreen/blob/patstatcat/Open-ILS/web/js/ui/default/actor/user/register.js|Open-ILS/web/js/ui/default/actor/user/register.js]]
-  * [[https://github.com/sprater/Evergreen/blob/patcatstat/Open-ILS/src/templates/actor/user/register.tt2|Open-ILS/src/templates/actor/user/register.tt2]]
-  * [[https://github.com/sprater/Evergreen/blob/patcatstat/Open-ILS/web/js/ui/default/actor/user/register.js|Open-ILS/web/js/ui/default/actor/user/register.js]]
 ===== Tests =====
@@ Line 96: / Line 94: @@
   - Don’t enter values for the required statistical categories.   Confirm that the record will be saved with the specified default value.
   - Confirm that the user cannot enter their own values.
-  - Edit an existing patron and repeat the tests in step 5 and 6.
+  - Edit an existing patron.
+  - Don’t enter values for the required statistical categories.   Confirm that the record will be saved with the previously-saved default.
+  - Confirm that the user cannot enter their own values.
 **Test suite 2:**  Verify required patron statistical field with fixed values and no entry marked as default
@@ Line 123: / Line 123: @@
   - Confirm that a user can save their record without entering any values in the optional category.  Confirm that the value saved is the default value.
   - Confirm that a user cannot enter their own values and must select from the drop-down if they choose to fill in the field.
-  - Edit an existing patron and repeat steps 4 and 5.
+  - Edit an existing patron.
+  - Confirm that a user can save their record without entering any values in the optional category.  Confirm that no value is saved.
+  - Confirm that a user cannot enter their own values and must select from the drop-down if they choose to fill in the field.
+  - Confirm that if no value was previously saved for the optional category, the patron edit screen displays an empty field for the category.
 **Test suite 5:**  Verify optional patron statistical field with fixed values and no entry marked as default