Evergreen DokuWiki

User Tools

Site Tools

You are here: start » dev » signoff_review_checklist
dev:signoff_review_checklist

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revisionPrevious revision
Next revision		Previous revision
Last revisionBoth sides next revision
dev:signoff_review_checklist [2015/08/05 16:36] – add two checklist items based on QA requirements approved at the 2015-08-05 dev meeting gmcharltondev:signoff_review_checklist [2022/02/10 13:34] – external edit 127.0.0.1
Line 11: Line 11:
 | | If the change introduces a new dependency, has that dependency been added to Makefile.install, and called out in the Release Notes, and a heads-up given to the broader community of testers / fellow developers / distro maintainers? | | | If the change introduces a new dependency, has that dependency been added to Makefile.install, and called out in the Release Notes, and a heads-up given to the broader community of testers / fellow developers / distro maintainers? |
 | | If the change removes a dependency, has that dependency been removed from Makefile.install? | | | If the change removes a dependency, has that dependency been removed from Makefile.install? |
-| | If there is a schema change, has the upgrade SQL script been generated with the correct update ID #, and does it match the number for ''config.upgrade_log'' in ''Open-ILS/src/sql/Pg/002.schema.config.sql''? |+| | **for the committer who pushes the patch(es)** If there is a schema change, have you (the patch-pusher) updated the upgrade SQL and ''Open-ILS/src/sql/Pg/002.schema.config.sql'' with a schema change ID? |
 | | Does "''eg_db_config.pl --create-database --create-schema --load-all-sample''" return without errors? (consider running a second time with "''| grep ERROR''" if the output is overwhelming) | | | Does "''eg_db_config.pl --create-database --create-schema --load-all-sample''" return without errors? (consider running a second time with "''| grep ERROR''" if the output is overwhelming) |
 | | Do all of the commits have commit messages with a) short first line summary; b) a description with lines less than 72 chars wide; c) ''Signed-off by'' line indicating DCO compliance; d) appropriate ''Author'' credit? | | | Do all of the commits have commit messages with a) short first line summary; b) a description with lines less than 72 chars wide; c) ''Signed-off by'' line indicating DCO compliance; d) appropriate ''Author'' credit? |
Line 17: Line 17:
 | | Does the change include appropriate comments for more complicated bits of code / database schema objects? | | | Does the change include appropriate comments for more complicated bits of code / database schema objects? |
 | | If third-party code is being integrated in the codebase, does it fall under a license compliant with ours (GPL v2, with the "or later" clause)? | | | If third-party code is being integrated in the codebase, does it fall under a license compliant with ours (GPL v2, with the "or later" clause)? |
-| | (//Docs//) Do ''a2x --format epub root.txt'', ''a2x --format pdf root.txt'', and ''asciidoc root.txt'' all return cleanly? |+| | (//Docs//) Do ''a2x --format epub root.txt'', ''a2x --fop root.txt'', and ''asciidoc root.txt'' all return cleanly? |
dev/signoff_review_checklist.txt · Last modified: 2022/09/15 10:16 by sandbergja
Except where otherwise noted, content on this wiki is licensed under the following license: CC Attribution-Share Alike 4.0 International
CC Attribution-Share Alike 4.0 International Donate Powered by PHP Valid HTML5 Valid CSS Driven by DokuWiki

© 2008-2022 GPLS and others. Evergreen is open source software, freely licensed under GNU GPLv2 or later.
The Evergreen Project is a U.S. 501(c)3 non-profit organization.