dev:signoff_review_checklist
Differences
This shows you the differences between two versions of the page.
Both sides previous revisionPrevious revisionNext revision | Previous revision | ||
dev:signoff_review_checklist [2015/08/05 16:36] – add two checklist items based on QA requirements approved at the 2015-08-05 dev meeting gmcharlton | dev:signoff_review_checklist [2022/09/15 10:16] (current) – Updating the docs commands sandbergja | ||
---|---|---|---|
Line 11: | Line 11: | ||
| | If the change introduces a new dependency, has that dependency been added to Makefile.install, | | | If the change introduces a new dependency, has that dependency been added to Makefile.install, | ||
| | If the change removes a dependency, has that dependency been removed from Makefile.install? | | | If the change removes a dependency, has that dependency been removed from Makefile.install? | ||
- | | | If there is a schema change, | + | | | **for the committer who pushes the patch(es)** |
| | Does "'' | | | Does "'' | ||
| | Do all of the commits have commit messages with a) short first line summary; b) a description with lines less than 72 chars wide; c) '' | | | Do all of the commits have commit messages with a) short first line summary; b) a description with lines less than 72 chars wide; c) '' | ||
Line 17: | Line 17: | ||
| | Does the change include appropriate comments for more complicated bits of code / database schema objects? | | | | Does the change include appropriate comments for more complicated bits of code / database schema objects? | | ||
| | If third-party code is being integrated in the codebase, does it fall under a license compliant with ours (GPL v2, with the "or later" clause)? | | | | If third-party code is being integrated in the codebase, does it fall under a license compliant with ours (GPL v2, with the "or later" clause)? | | ||
- | | | (// | + | | | (// |
dev/signoff_review_checklist.1438806999.txt.gz · Last modified: 2022/02/10 13:34 (external edit)